qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2] puv3: always compile-check debug printf


From: Anishka0107
Subject: [Qemu-devel] [PATCH v2] puv3: always compile-check debug printf
Date: Thu, 16 Mar 2017 11:11:33 +0530

     To prevent bitrot of the format string of the debug statement, files with
     conditional debug statements should ensure that printf is compiled always,
     and enclosed within if(0) statements and not in #ifdef.

Signed-off-by: Anishka Gupta <address@hidden>
---
 include/hw/unicore32/puv3.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/hw/unicore32/puv3.h b/include/hw/unicore32/puv3.h
index e268484..9fdf0a1 100644
--- a/include/hw/unicore32/puv3.h
+++ b/include/hw/unicore32/puv3.h
@@ -46,8 +46,7 @@
 #define DPRINTF(fmt, ...)
     if (DEBUG_PUV3) {
         fprintf(stderr, "%s: " fmt , __func__, ## __VA_ARGS__)
-    }
-    else {
+    } else {
         do {} while (0)
     }
 
-- 
2.5.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]