Re: [Qemu-devel] [PATCH] vnc: fix a qio-channel leak

[Philippe Mathieu-Daudé]

On 03/17/2017 07:14 AM, Daniel P. Berrange wrote:
> On Fri, Mar 17, 2017 at 01:28:02PM +0400, Marc-André Lureau wrote:
> > Spotted by ASAN.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > ---
> >  ui/vnc.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Reviewed-by: Daniel P. Berrange <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> > diff --git a/ui/vnc.c b/ui/vnc.c
> > index 8bfb1e0685..6e93b883b5 100644
> > --- a/ui/vnc.c
> > +++ b/ui/vnc.c
> > @@ -3677,6 +3677,7 @@ static int vnc_display_listen_addr(VncDisplay *vd,
> >          qio_channel_set_name(QIO_CHANNEL(sioc), name);
> >          if (qio_channel_socket_listen_sync(
> >                  sioc, rawaddrs[i], listenerr == NULL ? &listenerr : NULL) < 0) 
> > {
> > +            object_unref(OBJECT(sioc));
> >              continue;
> >          }
> >          listening = true;
>
> Regards,
> Daniel