Re: [Qemu-devel] [PATCH] cryptodev: fix asserting single queue

[Halil Pasic]

On 03/22/2017 01:36 PM, Halil Pasic wrote:
> We already check for queues == 1 in cryptodev_builtin_init and when that
> is not true raise an error. But before that error is reported the
> assertion in cryptodev_builtin_cleanup kicks in (because object is being
> finalized and freed).
> 
> Let's remove assert(queues == 1) form cryptodev_builtin_cleanup as it
> does only harm and no good.
> 
> Signed-off-by: Halil Pasic <address@hidden>

Sorry guys, I forgot to give credit to the reporter.

Reported-by: Boris Fiuczynski <address@hidden>
> ---
>  backends/cryptodev-builtin.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c
> index 82a068e..137c7a6 100644
> --- a/backends/cryptodev-builtin.c
> +++ b/backends/cryptodev-builtin.c
> @@ -359,8 +359,6 @@ static void cryptodev_builtin_cleanup(
>          }
>      }
> 
> -    assert(queues == 1);
> -
>      for (i = 0; i < queues; i++) {
>          cc = backend->conf.peers.ccs[i];
>          if (cc) {
>