Re: [Qemu-devel] [PATCH for-2.9] block: Declare blockdev-add and blockdev-del supported

[Markus Armbruster]

Max Reitz <address@hidden> writes:

> On 21.03.2017 17:57, Markus Armbruster wrote:
>> It's been a long journey, but here we are.
>> 
>> x-blockdev-remove-medium, x-blockdev-insert-medium and
>> x-blockdev-change need a bit more work, so leave them alone for now.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  blockdev.c             |  4 ++--
>>  qapi/block-core.json   | 14 +++++---------
>>  tests/qemu-iotests/139 |  8 ++++----
>>  tests/qemu-iotests/141 |  4 ++--
>>  tests/qemu-iotests/147 |  2 +-
>>  5 files changed, 14 insertions(+), 18 deletions(-)
>
> [...]
>
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index 0f132fc..5d913d4 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -2907,11 +2907,7 @@
>>  # BlockBackend will be created; otherwise, @node-name is mandatory at the 
>> top
>>  # level and no BlockBackend will be created.
>>  #
>> -# Note: This command is still a work in progress.  It doesn't support all
>> -# block drivers among other things.  Stay away from it unless you want
>> -# to help with its development.
>> -#
>> -# Since: 1.7
>> +# Since: 2.9
>>  #
>>  # Example:
>>  #
>> @@ -2957,7 +2953,7 @@
>>  { 'command': 'blockdev-add', 'data': 'BlockdevOptions', 'boxed': true }
>>  
>>  ##
>> -# @x-blockdev-del:
>> +# @blockdev-del:
>>  #
>>  # Deletes a block device that has been added using blockdev-add.
>>  # The command will fail if the node is attached to a device or is
>> @@ -2969,7 +2965,7 @@
>>  # experimental. Stay away from it unless you want to help with its
>>  # development.
>
> This part of the comment very much looks like it should be removed.

v2 coming up, thanks!

> Max
>
>>  #
>> -# Since: 2.5
>> +# Since: 2.9
>>  #
>>  # Example:
>>  #
>
> [...]