[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.9] block: Declare blockdev-add and bloc
Re: [Qemu-devel] [PATCH v2 for-2.9] block: Declare blockdev-add and blockdev-del supported
Wed, 22 Mar 2017 12:52:13 -0500
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
On 03/22/2017 12:13 PM, Max Reitz wrote:
> On 22.03.2017 17:20, Markus Armbruster wrote:
>> It's been a long journey, but here we are.
>> The supported blockdev-add is not compatible to its experimental
>> predecessors; bump all Since: tags to 2.9.
>> x-blockdev-remove-medium, x-blockdev-insert-medium and
>> x-blockdev-change need a bit more work, so leave them alone for now.
>> Signed-off-by: Markus Armbruster <address@hidden>
>> * Another "command is considered experimental" comment dropped [Max]
>> * More Since: tags updated to 2.9, commit message improved, R-bys dropped
> Do you want to do this recursively? There are things such as
> BlkdebugSetStateOptions or ReplicationMode which are only used by the
> corresponding BlockdevOptions*, so they too are basically only supported
> as of 2.9.
> I don't have a strong opinion, but I think I personally wouldn't bother
> with any of these structures and just update the tag for blockdev-add
I also don't have a strong opinion, and think it may actually be a bit
more time consuming to audit which types are recursively used only by
blockdev-add (and no where else) than to just leave them be. But I'm
also okay if you like bumping the numbers to the point where the struct
was marked stable, and where we have to start thinking about back-compat
ramifications when modifying the struct.
> You being fine with me would be enough to convince me, so:
> Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Description: OpenPGP digital signature