Re: [Qemu-devel] [PULL v2 for-2.9 17/17] qapi: Fix QemuOpts visitor regression on unvisited input

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 03/22/2017 12:48 PM, Markus Armbruster wrote:
>> From: Eric Blake <address@hidden>
>> 
>> An off-by-one in commit 15c2f669e meant that we were failing to
>> check for unparsed input in all QemuOpts visitors.  Recent testsuite
>> additions show that fixing the obvious bug with bogus fields will
>> also fix the case of an incomplete list visit; update the tests to
>> match the new behavior.
>> 
>> Simple testcase:
>> 
>> ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic -qmp stdio -numa 
>> node,size=1g
>> 
>> failed to diagnose that 'size' is not a valid argument to -numa, and
>> now once again reports:
>> 
>> qemu-system-x86_64: -numa node,size=1g: Invalid parameter 'size'
>> 
>> See also https://bugzilla.redhat.com/show_bug.cgi?id=1434666
>> 
>> CC: address@hidden
>> Signed-off-by: Eric Blake <address@hidden>
>> Reviewed-by: Michael Roth <address@hidden>
>> Tested-by: Laurent Vivier <address@hidden>
>> Message-Id: <address@hidden>
>> Reviewed-by: Markus Armbruster <address@hidden>
>> [Fixup squashed in]
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Fixup squashed into the wrong patch. End result is the same, though, so
> not sure if it is worth a v3 pull request.

Rats...  thanks for paying attention!