Re: [Qemu-devel] [PATCH v10 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

[Eric Blake]

On 03/27/2017 01:25 PM, ashish mittal wrote:

>>>
>>> Sample command line using URI syntax:
>>> qemu-img convert -f raw -O raw -n
>>> /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad
>>> vxhs://192.168.0.1:9999/c6718f6b-0401-441d-a8c3-1f0064d75ee0
>>
>> Do we really need URI syntax, now that we have -blockdev-add going into 2.9?
>>
> 
> Having it just makes manual testing with CLI easier (less to type).
> Would like to retain it for now, unless having this is a problem.
> Removing it will also require rework and retesting of the qemu-iotests
> patch.

At this point, it's a maintenance burden. We're trying to get rid of
QemuOpts madness in favor of sane QMP design, and every new driver that
adds yet another URI hack on top of QemuOpts makes it that much harder
to get rid of the cruft.  I'm not going to be the one to outright reject
a URI scheme as long as the QMP works with equal features.  But given
the churn currently going on about RBD support for 2.9, I want to make
absolutely sure we get the QMP part exactly right, and don't have to
maintain any extra translation layers to URI than absolutely necessary.


>>
>> No Copyright notice?  The GPL works by virtue of copyright law, so
>> generally a copyright holder should be mentioned.
>>
> 
> I guess what's missing is the "Copyright (c) Veritas, LLC. 2017" line.
> Is that correct?

Yes. (Your company's legal team may have specific requirements or advice
on exactly how to format the line; I can't speak to whether you have
complied with those checklists, but from my perspective your proposal
looks fine).


>>> +##
>>> +{ 'struct': 'BlockdevOptionsVxHS',
>>> +  'data': { 'vdisk-id': 'str',
>>> +            'server': 'InetSocketAddress',
>>
>> Do you want to use the new InetSocketAddressBase (just host and port,
>> eliminating things like 'to' that don't make much sense in this context)?
>>
> 
> Don't see InetSocketAddressBase in the latest code. Could you please
> give me a usage example for reference? Thanks!

Part of Markus' pending series that you'd have to rebase on ;)
https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg05215.html


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature