Re: [Qemu-devel] [PATCH RFC v3 for-2.9 08/11] rbd: Revert -blockdev and -drive parameter auth-supported

[Eric Blake]

On 03/28/2017 03:24 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
> 
>> On 03/27/2017 08:26 AM, Markus Armbruster wrote:
>>> This reverts half of commit 0a55679.  We're having second thoughts on
>>> the QAPI schema (and thus the external interface), and haven't reached
>>> consensus, yet.  Issues include:
>>>
>>
>>> Let's avoid painting ourselves into a corner now, and revert the
>>> feature for 2.9.
>>
>> There may still be some tweaks to improve the commit message and/or code
>> comments to clarify things that tripped me up until later in the
>> subthread, but now that I understand the difference between pseudo-file
>> format (where the key-value pair backdoor still works for libvirt's
>> usage of -drive file=rbd:...) and QemuOpts format (-drive driver=rbd,...
>> which didn't really exist in 2.8, and where we don't want to bake in
>> something we don't like in 2.9), I agree with the move.
> 
> I'm inserting ...
> 
>>> Note that users can still configure authentication methods with a
>>> configuration file.  They probably do that anyway if they use Ceph
>>> outside QEMU as well.
> 
> ... this hint right here:
> 
>    Further note that this doesn't affect use of key "auth-supported" in
>    -drive file=rbd:...:key=value.
> 
> Good enough?

Yes, that does the trick.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature