[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ipmi: use parens to avoid unexpected macro var
Re: [Qemu-devel] [PATCH] ipmi: use parens to avoid unexpected macro var evaluation
Thu, 30 Mar 2017 13:14:24 -0400
On 30 March 2017 at 12:12, Corey Minyard <address@hidden> wrote:
> This isn't quite right, a lot of these need parenthesis around the whole
> thing, and some of the macros are unused and need to be removed.
> I had submitted something for this a while ago, but it hadn't been
> taken. I will re-submit.
Ok, thanks and apologies for not noticing existing patch and discussion.
On the topic of building with recent Clang there are also a large
number of warnings of the form "taking the address of a packed member
'magic' of class or structure 'QCowHeader' may result in an unaligned
pointer value [-Waddress-of-packed-member]". Unfortunately this
warning seems to be overly aggressive and prone to false positives.