Re: [Qemu-devel] [PATCH v3] hmp: fix "info cpu" segfault

[Dr. David Alan Gilbert]

* Iwona Kotlarska (address@hidden) wrote:
> Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and executing
> "dump-guest-memory /dev/null 0 8192" results in segfault.
> Fix by checking if we have CPU.
> 
> Signed-off-by: Iwona Kotlarska <address@hidden>

Queued.

I've fixed up the title to
  hmp: fix "dump-quest-memory" segfault

since that's the actual command it fixes.

Dave

> ---
>  target/i386/arch_dump.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c
> index 5a2e4be5d0..fe0aa36932 100644
> --- a/target/i386/arch_dump.c
> +++ b/target/i386/arch_dump.c
> @@ -391,8 +391,7 @@ int cpu_get_dump_info(ArchDumpInfo *info,
>  
>  #ifdef TARGET_X86_64
>      X86CPU *first_x86_cpu = X86_CPU(first_cpu);
> -
> -    lma = !!(first_x86_cpu->env.hflags & HF_LMA_MASK);
> +    lma = first_cpu && (first_x86_cpu->env.hflags & HF_LMA_MASK);
>  #endif
>  
>      if (lma) {
> -- 
> 2.12.0
> 
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK