[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] main_loop: Make main_loop_wait() return void

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] main_loop: Make main_loop_wait() return void
Date: Fri, 31 Mar 2017 14:54:22 +0100

On 31 March 2017 at 14:51, Peter Maydell <address@hidden> wrote:
> In commit e330c118f2a5a the last usage of main_loop_wait() that cared
> about the return value was changed to no longer use it. Drop the
> now-useless return value and make the function return void.
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Coverity complains (CID 1372464) about main_loop() calling
> main_loop_wait() and ignoring its return value. I suspect
> this change will just displace that to within main_loop_wait()
> itself since the underlying issue there is "the ppoll() that
> gets called to poll fds can return an error code, but what
> do we do if it does?". Suggestions on that point welcome.
> I guess this will make the compiler warn about ret being
> set and never used if CONFIG_SLIRP is not defined, which
> is irritating. I'm postponing messing about with fixing
> that in favour of seeing whether anybody has a good answer
> to the question above (which might make it moot).
> ---

...oops, I meant to tag this RFC; never mind.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]