[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9 0/2] curl: Extend and fix b

From: Jeff Cody
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9 0/2] curl: Extend and fix blockdev-add schema
Date: Fri, 31 Mar 2017 15:00:03 -0400
User-agent: Mutt/1.5.24 (2015-08-30)

On Fri, Mar 31, 2017 at 02:04:29PM +0200, Max Reitz wrote:
> Yes, it's yet another episode in our popular
> get-blockdev-add-ready-for-2.9 drama!
> Right now, the schema for the curl block driver is seriously lacking.
> This series improves things at least a bit.
> To improve things seriously, we might want to structure the URL instead
> of it being just a plain string, and we might want to split the cookie
> string into a list of dicts or something similar. However, strictly
> speaking our curl block driver is *not* an (ht|f)tps? block driver but
> just a curl driver. All it does is pass some options to libcurl and then
> send and receive data from it. (We really should have just named it
> "curl" from the start.)
> Therefore, it probably is for the best to leave these options rather
> opaque and let libcurl do the interpretation.
> Max Reitz (2):
>   qapi/curl: Extend and fix blockdev-add schema
>   block/curl: Check protocol prefix
>  qapi/block-core.json | 103 
> ++++++++++++++++++++++++++++++++++++++++++++++-----
>  block/curl.c         |  10 +++++
>  2 files changed, 104 insertions(+), 9 deletions(-)
> -- 
> 2.12.1


Applied to my block branch:

git://github.com/codyprime/qemu-kvm-jtc.git block


reply via email to

[Prev in Thread] Current Thread [Next in Thread]