[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] vmstatification: i386 FPReg

From: Juan Quintela
Subject: Re: [Qemu-devel] [PATCH 2/3] vmstatification: i386 FPReg
Date: Wed, 05 Apr 2017 21:26:46 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> Convert the fpreg save/restore to use VMSTATE_ macros rather than
> .get/.put.
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>

But if you have to respin

> +typedef struct x86_FPReg_tmp {
> +    FPReg *parent;
> +    uint64_t tmp_mant;
> +    uint16_t tmp_exp;
> +} x86_FPReg_tmp;

Too many tmp's?  I am pretty sure that you can call the fields mant and exp.

Later, Juan.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]