[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 3/9] block: honor BDRV_O_ALLOW_RDWR whe
Re: [Qemu-devel] [PATCH for-2.10 3/9] block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only
Wed, 5 Apr 2017 20:20:28 -0400
On Wed, Apr 05, 2017 at 02:26:53PM -0500, Eric Blake wrote:
> On 04/05/2017 02:20 PM, John Snow wrote:
> > Conceptually straightforward.
> > looks like this might change behavior for... RBD and vvfat, right?
> > RBD is the subject of this series so we'll just assume that was broken
> > and stupid.
Yes on RBD, and that change is intentional.
> > What's vvfat's story? It always set the read-only property to false
> > regardless of what you asked for?
> vvfat is even stupider than that - it has its own independent property
> 'rw' that determines whether to allow write operations, separate from
> the inherited BDS readonly property.
Yes, it is very odd. But if we have copy_on_read enabled, or explicitly set
the block device to read-only via QAPI or -drive, I think that those should
[Qemu-devel] [PATCH for-2.10 4/9] block: code movement, Jeff Cody, 2017/04/05
[Qemu-devel] [PATCH for-2.10 2/9] block: do not set BDS read_only if copy_on_read enabled, Jeff Cody, 2017/04/05
[Qemu-devel] [PATCH for-2.10 5/9] block: introduce bdrv_try_set_read_only(), Jeff Cody, 2017/04/05