[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 43/46] block: Assertions for write permissions
From: |
Richard W.M. Jones |
Subject: |
Re: [Qemu-devel] [PULL 43/46] block: Assertions for write permissions |
Date: |
Thu, 6 Apr 2017 21:59:39 +0100 |
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Tue, Feb 28, 2017 at 09:36:42PM +0100, Kevin Wolf wrote:
> This adds assertions that ensure that the necessary write permissions
> have been granted before someone attempts to write to a node.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Acked-by: Fam Zheng <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> block/io.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/block/io.c b/block/io.c
> index 2592ca1..4c79745 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -945,6 +945,8 @@ static int coroutine_fn
> bdrv_co_do_copy_on_readv(BdrvChild *child,
> size_t skip_bytes;
> int ret;
>
> + assert(child->perm & (BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE));
This assertion is thrown in the libguestfs test suite. I filed a bug
about it against the Fedora package:
https://lists.gnu.org/archive/html/qemu-block/2017-02/msg01305.html
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v
- Re: [Qemu-devel] [PULL 43/46] block: Assertions for write permissions,
Richard W.M. Jones <=