Re: [Qemu-devel] [PATCH] 9pfs: xattr: fix memory leak in v9fs_list_xattr

[Greg Kurz]

On Fri,  7 Apr 2017 03:48:52 -0700
Li Qiang <address@hidden> wrote:

> Free 'orig_value' in error path.
> 
> Signed-off-by: Li Qiang <address@hidden>
> ---

Good catch. I'll send a pull req later today.

Cheers.

--
Greg

>  hw/9pfs/9p-xattr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/9pfs/9p-xattr.c b/hw/9pfs/9p-xattr.c
> index eec160b..d05c1a1 100644
> --- a/hw/9pfs/9p-xattr.c
> +++ b/hw/9pfs/9p-xattr.c
> @@ -108,6 +108,7 @@ ssize_t v9fs_list_xattr(FsContext *ctx, const char *path,
>      g_free(name);
>      close_preserve_errno(dirfd);
>      if (xattr_len < 0) {
> +        g_free(orig_value);
>          return -1;
>      }
>

pgpiunID71FG8.pgp
Description: OpenPGP digital signature