[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/10] blockjob: move iostatus reset inside bloc
Re: [Qemu-devel] [PATCH 06/10] blockjob: move iostatus reset inside block_job_user_resume
Mon, 10 Apr 2017 10:33:54 +0100
On Thu, Mar 23, 2017 at 06:39:24PM +0100, Paolo Bonzini wrote:
> Outside blockjob.c, the block_job_iostatus_reset function is used once
> in the monitor and once in BlockBackend. When we introduce the block
> job mutex, block_job_iostatus_reset's client is going to be the block
> layer (for which blockjob.c will take the block job mutex) rather than
> the monitor (which will take the block job mutex by itself).
> The monitor's call to block_job_iostatus_reset from the monitor comes
> just before the sole call to block_job_user_resume, so reset the
> iostatus directly from block_job_iostatus_reset. This will avoid
> the need to introduce separate block_job_iostatus_reset and
> block_job_iostatus_reset_locked APIs.
> After making this change, move the function together with the others
> that were moved in the previous patch.
> Signed-off-by: Paolo Bonzini <address@hidden>
> blockdev.c | 1 -
> blockjob.c | 11 ++++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
Description: PGP signature