[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 15/19] tests: crypto: add cipher speed
Re: [Qemu-devel] [PATCH for-2.10 15/19] tests: crypto: add cipher speed case
Mon, 10 Apr 2017 18:25:34 +0800
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1
Ok, I'll take all your suggestions, and fix them in next version.
On 2017/4/10 17:51, Daniel P. Berrange wrote:
> On Mon, Apr 10, 2017 at 05:00:58PM +0800, Longpeng(Mike) wrote:
>> Now we have afalg-backend and libiary-backend, it's necessary
>> to add the speed test in test-crypto-cipher.
>> We can use "./tests/test-crypto-cipher speed" to do the speed
> This is not using any of the existing code for the benchmark, so there's
> no real benefit to having it in this file.
> I'd suggest creating a separate test program for performance benchmarking,
> eg tests/benchmark-crypto-cipher, that would be invoked separately as &
> when needed ie skipped by make check-unit, but run by a 'make check-speed'.
> Likewise for the other tests you've changed later in this series.