[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/5] cadence_gem: Read the correct queue desc
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/5] cadence_gem: Read the correct queue descriptor |
Date: |
Mon, 10 Apr 2017 13:39:03 +0100 |
On 5 April 2017 at 00:40, Alistair Francis <address@hidden> wrote:
> Read the correct descriptor instead of hardcoding the first (q=0).
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
>
> hw/net/cadence_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index d4de8ad..17c229d 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -790,8 +790,8 @@ static void gem_get_rx_desc(CadenceGEMState *s, int q)
> {
> DB_PRINT("read descriptor 0x%x\n", (unsigned)s->rx_desc_addr[q]);
> /* read current descriptor */
> - cpu_physical_memory_read(s->rx_desc_addr[0],
> - (uint8_t *)s->rx_desc[0],
> sizeof(s->rx_desc[0]));
> + cpu_physical_memory_read(s->rx_desc_addr[q],
> + (uint8_t *)s->rx_desc[q],
> sizeof(s->rx_desc[q]));
>
> /* Descriptor owned by software ? */
> if (rx_desc_get_ownership(s->rx_desc[q]) == 1) {
> --
> 2.9.3
>
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v1 5/5] xlnx-zynqmp: Set the Cadence GEM revision, (continued)
- [Qemu-devel] [PATCH v1 5/5] xlnx-zynqmp: Set the Cadence GEM revision, Alistair Francis, 2017/04/04
- [Qemu-devel] [PATCH v1 4/5] cadence_gem: Make the revision a property, Alistair Francis, 2017/04/04
- [Qemu-devel] [PATCH v1 3/5] cadence_gem: Only trigger interrupts if the status register is set, Alistair Francis, 2017/04/04
- [Qemu-devel] [PATCH v1 2/5] cadence_gem: Correct the multi-queue can rx logic, Alistair Francis, 2017/04/04
- [Qemu-devel] [PATCH v1 1/5] cadence_gem: Read the correct queue descriptor, Alistair Francis, 2017/04/04