[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] qga: improve error handling in transfer_
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] qga: improve error handling in transfer_memory_block |
Date: |
Mon, 10 Apr 2017 20:20:26 -0500 |
User-agent: |
alot/0.5.1 |
Quoting Philippe Mathieu-Daudé (2017-04-07 17:20:16)
> Suggested-by: Michael Roth <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
> ---
>
> Michael should I use Signed-off-by instead of the Suggested-by (since it is
> your
> code)?
I suppose it could go either way depending on the circumstances
(assuming you've asked for / obtained their SoB obviously), but
speaking for myself here I don't think it's necessary.
>
> qga/commands-posix.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index fc45102a1e..ca5a24b2c9 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -2128,6 +2128,9 @@ static void transfer_memory_block(GuestMemoryBlock
> *mem_blk, bool sys2memblk,
> if (errno == ENOENT) {
> result->response =
> GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORTED;
> + } else {
> + result->response =
> + GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_FAILED;
> }
> goto out1;
> }
> --
> 2.11.0
>
- [Qemu-devel] [PATCH v2 0/4] 3 easy-to-fix clang warnings, 1 error code fixed, Philippe Mathieu-Daudé, 2017/04/07
- [Qemu-devel] [PATCH v2 1/4] usb-ccid: make ccid_write_data_block() cope with null buffers, Philippe Mathieu-Daudé, 2017/04/07
- [Qemu-devel] [PATCH v2 2/4] device_tree: fix compiler warnings (clang 5), Philippe Mathieu-Daudé, 2017/04/07
- [Qemu-devel] [PATCH v2 3/4] qga: fix compiler warnings (clang 5), Philippe Mathieu-Daudé, 2017/04/07
- [Qemu-devel] [PATCH v2 4/4] qga: improve error handling in transfer_memory_block, Philippe Mathieu-Daudé, 2017/04/07
- Re: [Qemu-devel] [PATCH v2 4/4] qga: improve error handling in transfer_memory_block,
Michael Roth <=
- Re: [Qemu-devel] [PATCH v2 0/4] 3 easy-to-fix clang warnings, 1 error code fixed, Michael Tokarev, 2017/04/23