[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/4] pam: setup pc.bios

From: Xu, Anthony
Subject: Re: [Qemu-devel] [PATCH 4/4] pam: setup pc.bios
Date: Tue, 11 Apr 2017 01:42:08 +0000

> I think this is wrong, the high copy should remain read-only or pflash
> stops working when you remove PAM.

I tried to set pc.bios as read-only and isa.bios as read&write,
it doesn't work. render_memory_region doesn't honor readonly
field of alias MemoryRegion. 

Two FlatRanges created for pc.bios and isa.bios point to the same
MemoryRegion pc.bios. Both get readonly from pc.bios.

Is this a bug or by design?

Pc.bios and isa.bios are backed by the same memory block,
so it may cause CPU TLB alias, any issue here?

> The comment only explains the "what" but not the "why" and the "why" is
> not in the commit message.  See also here:
Will do.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]