[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9?] block/nfs: Do not strcmp() with NULL
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH for-2.9?] block/nfs: Do not strcmp() with NULL |
Date: |
Tue, 11 Apr 2017 15:58:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Max Reitz <address@hidden> writes:
> Parsing the URI is not required to give us a scheme; uri->scheme may be
> NULL.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/nfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/nfs.c b/block/nfs.c
> index 0816678307..0c7d5619fe 100644
> --- a/block/nfs.c
> +++ b/block/nfs.c
> @@ -83,7 +83,7 @@ static int nfs_parse_uri(const char *filename, QDict
> *options, Error **errp)
> error_setg(errp, "Invalid URI specified");
> goto out;
> }
> - if (strcmp(uri->scheme, "nfs") != 0) {
> + if (!uri->scheme || strcmp(uri->scheme, "nfs") != 0) {
> error_setg(errp, "URI scheme must be 'nfs'");
> goto out;
> }
Consider g_strcmp0().