[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 07/13] block: Use simpler QDict/QList scalar

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v4 07/13] block: Use simpler QDict/QList scalar insertion macros
Date: Wed, 12 Apr 2017 08:52:48 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> We now have macros in place to make it less verbose to add a scalar
> to QDict and QList, so use them.
> Patch created mechanically via:
>   spatch --sp-file scripts/coccinelle/qobject.cocci \
>     --macro-file scripts/cocci-macro-file.h --dir block --in-place
> then touched up manually to fix a couple of '?:' back to original spacing.
> For ease of review, the mechanical work was split by tree location:
> this only touches files under block/; there are other block-related
> files (like top-level block.c) that will be fixed in a later global
> cleanup.

I don't like this split.  Splitting out *subsystems* may ease review,
but this splits out directory block/, which is only a part of the block
subsystem.  Explaining this takes you more than three dozen words.  I'd
prefer either the whole block subsystem (as defined in MAINTAINERS)
split out, or no split.

I'm willing to accept the split as is anyway if block maintainers are
okay with it.

I'm also willing to squash the three parts on commit.

> Signed-off-by: Eric Blake <address@hidden>
> Acked-by: Richard W.M. Jones <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]