[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9?] block/io: Comment out permission asser
Re: [Qemu-devel] [PATCH for-2.9?] block/io: Comment out permission assertions
Wed, 12 Apr 2017 15:28:43 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
On 12/04/2017 15:18, Kevin Wolf wrote:
> Am 11.04.2017 um 17:07 hat Laurent Vivier geschrieben:
>> On 11/04/2017 16:58, Kevin Wolf wrote:
>>> Am 11.04.2017 um 16:50 hat Max Reitz geschrieben:
>>>> In case of block migration, there may be writes to BlockBackends that do
>>>> not have the write permission taken. Before this issue is fixed (which
>>>> is not going to happen in 2.9), we therefore cannot assert that this is
>>>> the case.
>>>> Suggested-by: Kevin Wolf <address@hidden>
>>>> Signed-off-by: Max Reitz <address@hidden>
>>> I tested block migration (migrate -b). Leaving postcopy migration, which
>>> is apparently also broken, to Laurent.
>>> Reviewed-by: Kevin Wolf <address@hidden>
>>> Tested-by: Kevin Wolf <address@hidden>
>> With postcopy migration
>> Tested-by: Laurent Vivier <address@hidden>
> I think the following is the real fix for postcopy migration, in case
> someone wants to give it a test before I send it as a proper patch (the
> bug is a result of duplicating code between precopy/postcopy migration
> instead of sharing it - commit d35ff5e6 only updated one of both).
Tested with my test case and it works fine.