[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions
Date: Thu, 13 Apr 2017 12:19:00 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

13.04.2017 02:40, John Snow wrote:

On 04/12/2017 07:36 PM, Eric Blake wrote:
On 04/12/2017 05:47 PM, John Snow wrote:

On 04/12/2017 01:49 PM, Eric Blake wrote:
We had several functions that no one was using, and which used
sector-based interfaces.  I'm trying to convert towards byte-based
interfaces, so it's easier to just drop the unused functions:


Signed-off-by: Eric Blake <address@hidden>
  include/block/dirty-bitmap.h |  8 --------
  block/dirty-bitmap.c         | 34 ----------------------------------
  2 files changed, 42 deletions(-)

I think it's likely Vladimir is or at least was relying on some of these
for his migration and persistence series.

Might be nice to let him chime in to see how much of a hassle this is.
Then let's add him in cc ;)

Err... I can't just summon people by mentioning them?

I'm okay if these functions stay because they have a user, but it would
also be nice if they were properly byte-based (like everything else in
dirty-bitmap at the end of my series).  So even if we remove them here,
we can revert the removal, and re-add them but with a sane interface.

OK, but I will offer to do the work in the interest of not slowing
things down any further.

Do you use any of these, Vladimir?

HI all!

only bdrv_dirty_bitmap_size() is used. No problem to add it back with my series next update

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]