[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/1] qemu-img: wait for convert coroutines to co

From: Peter Lieven
Subject: Re: [Qemu-devel] [PATCH 1/1] qemu-img: wait for convert coroutines to complete
Date: Tue, 18 Apr 2017 13:22:51 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

Am 18.04.2017 um 12:27 schrieb Denis V. Lunev:
From: Anton Nefedov <address@hidden>

We should wait for other coroutines on error path, i.e. one of coroutines
terminates with i/o error, before cleaning the common structures. In the
other case we would crash in a lot of different places. This behaviour
was introduced by commit 2d9187bc65.

Signed-off-by: Anton Nefedov <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Peter Lieven <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Max Reitz <address@hidden>
  qemu-img.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-img.c b/qemu-img.c
index b220cf7..3b04c5f 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1899,7 +1899,7 @@ static int convert_do_copy(ImgConvertState *s)
- while (s->ret == -EINPROGRESS) {
+    while (s->running_coroutines) {

Reviewed-by: Peter Lieven <address@hidden>

Thanks for catching this.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]