[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC 3/7] pci: Change pci_bus_new*() parameter to PCIHo

From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [RFC 3/7] pci: Change pci_bus_new*() parameter to PCIHostState
Date: Tue, 18 Apr 2017 16:36:58 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1

On 04/18/2017 04:30 PM, Eduardo Habkost wrote:
On Tue, Apr 18, 2017 at 04:27:23PM +0300, Marcel Apfelbaum wrote:
@@ -431,7 +430,7 @@ PCIBus *pci_register_bus(DeviceState *parent, const char 
     PCIBus *bus;

-    bus = pci_bus_new(parent, name, address_space_mem,
+    bus = pci_bus_new(PCI_HOST_BRIDGE(parent), name, address_space_mem,

If you request the parent to be PCI_HOST_BRIDGE, why don't you change also the 
signature of
pci_register_bus ?

I do it on patch 4/7.

Yes, I saw it :). at least it means I am following the patches...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]