[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 00/20] block: Image locking series
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v13 00/20] block: Image locking series |
Date: |
Thu, 20 Apr 2017 18:13:51 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, 04/20 12:03, Kevin Wolf wrote:
> Am 20.04.2017 um 10:32 hat Fam Zheng geschrieben:
> > > /var/tmp/patchew-tester-tmp-7vbaovju/src/block/file-posix.c: In function
> > > ‘raw_handle_lock_update’:
> > > /var/tmp/patchew-tester-tmp-7vbaovju/src/block/file-posix.c:1117:17:
> > > error: ‘lock_fd’ may be used uninitialized in this function
> > > [-Werror=maybe-uninitialized]
> > > qemu_close(lock_fd);
> > > ^~~~~~~~~~~~~~~~~~~
> > > cc1: all warnings being treated as errors
> > > /var/tmp/patchew-tester-tmp-7vbaovju/src/rules.mak:69: recipe for target
> > > 'block/file-posix.o' failed
> >
> > False positive. lock_fd is initialized in a "if (op == RAW_LT_PREPARE)"
> > branch
> > above, and we are in a "case RAW_LT_PREPARE" switch branch too.
>
> Even if it's a false positive, obviously we still need to work around
> the build failure.
Sure, easy to do. I'll initialize the variable.
Fam
- [Qemu-devel] [PATCH v13 16/20] tests: Disable image lock in test-replication, (continued)
- [Qemu-devel] [PATCH v13 16/20] tests: Disable image lock in test-replication, Fam Zheng, 2017/04/20
- [Qemu-devel] [PATCH v13 17/20] block: Workaround drive-backup sync=none for image locking, Fam Zheng, 2017/04/20
- [Qemu-devel] [PATCH v13 18/20] osdep: Add qemu_lock_fd and qemu_unlock_fd, Fam Zheng, 2017/04/20
- [Qemu-devel] [PATCH v13 20/20] tests: Add test-image-lock, Fam Zheng, 2017/04/20
- [Qemu-devel] [PATCH v13 19/20] file-posix: Add image locking in perm operations, Fam Zheng, 2017/04/20
- Re: [Qemu-devel] [PATCH v13 00/20] block: Image locking series, no-reply, 2017/04/20
- Re: [Qemu-devel] [PATCH v13 00/20] block: Image locking series, no-reply, 2017/04/20
- Re: [Qemu-devel] [PATCH v13 00/20] block: Image locking series, no-reply, 2017/04/20