[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 07/13] sm501: Fix device endianness
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v5 07/13] sm501: Fix device endianness |
Date: |
Thu, 20 Apr 2017 22:47:12 +0100 |
On 20 April 2017 at 21:43, BALATON Zoltan <address@hidden> wrote:
> We only emulate the sysbus device in its default LE mode and PCI is LE
> as well so specify this for registers and framebuffer memory.
>
> Signed-off-by: BALATON Zoltan <address@hidden>
> ---
I think it's worth a comment to the effect of:
Note that though the Linux kernel driver has code which
claims to handle both big and little endian, it is obviously
bogus for 16 bit and cannot be trusted as a source of
information on the framebuffer pixel format. This is
our best guess about device behaviour based on the specs.
(so if we find ourselves wondering about this mismatch
in a couple of years time at least we'll know why this
end is the way it is.)
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v5 00/13] Improvements for SM501 display controller emulation, BALATON Zoltan, 2017/04/20
- [Qemu-devel] [PATCH v5 13/13] ppc: Add SM501 device in ppc softmmu targets default configs, BALATON Zoltan, 2017/04/20
- [Qemu-devel] [PATCH v5 07/13] sm501: Fix device endianness, BALATON Zoltan, 2017/04/20
- Re: [Qemu-devel] [PATCH v5 07/13] sm501: Fix device endianness,
Peter Maydell <=
- [Qemu-devel] [PATCH v5 10/13] sm501: Add support for panel layer, BALATON Zoltan, 2017/04/20
- [Qemu-devel] [PATCH v5 03/13] sm501: Add missing arbitration control register, BALATON Zoltan, 2017/04/20
- [Qemu-devel] [PATCH v5 11/13] sm501: Add some more missing registers, BALATON Zoltan, 2017/04/20
- [Qemu-devel] [PATCH v5 09/13] sm501: Misc clean ups, BALATON Zoltan, 2017/04/20
- [Qemu-devel] [PATCH v5 05/13] sm501: Get rid of base address in draw_hwc_line, BALATON Zoltan, 2017/04/20
- [Qemu-devel] [PATCH v5 02/13] sm501: Use defined constants instead of literal values where available, BALATON Zoltan, 2017/04/20
- [Qemu-devel] [PATCH v5 04/13] sm501: QOMify, BALATON Zoltan, 2017/04/20
- [Qemu-devel] [PATCH v5 06/13] sm501: Add emulation of chip connected via PCI, BALATON Zoltan, 2017/04/20
- [Qemu-devel] [PATCH v5 12/13] sm501: Add vmstate descriptor, BALATON Zoltan, 2017/04/20
- [Qemu-devel] [PATCH v5 08/13] sm501: Fix hardware cursor, BALATON Zoltan, 2017/04/20