[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 07/13] sm501: Fix device endianness

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v5 07/13] sm501: Fix device endianness
Date: Thu, 20 Apr 2017 22:47:12 +0100

On 20 April 2017 at 21:43, BALATON Zoltan <address@hidden> wrote:
> We only emulate the sysbus device in its default LE mode and PCI is LE
> as well so specify this for registers and framebuffer memory.
> Signed-off-by: BALATON Zoltan <address@hidden>
> ---

I think it's worth a comment to the effect of:

Note that though the Linux kernel driver has code which
claims to handle both big and little endian, it is obviously
bogus for 16 bit and cannot be trusted as a source of
information on the framebuffer pixel format. This is
our best guess about device behaviour based on the specs.

(so if we find ourselves wondering about this mismatch
in a couple of years time at least we'll know why this
end is the way it is.)

Reviewed-by: Peter Maydell <address@hidden>

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]