[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-2.9 2/6] throttle: do not use invalid config in t
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL for-2.9 2/6] throttle: do not use invalid config in test |
Date: |
Fri, 21 Apr 2017 10:43:12 +0100 |
The (burst) max parameter cannot be smaller than the avg parameter.
There is a test case that uses avg = 56, max = 1 and gets away with it
because no input validation is performed by the test case.
This patch switches to valid test input parameters.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
tests/test-throttle.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/test-throttle.c b/tests/test-throttle.c
index bd7c501..089e937 100644
--- a/tests/test-throttle.c
+++ b/tests/test-throttle.c
@@ -205,8 +205,8 @@ static void test_config_functions(void)
orig_cfg.buckets[THROTTLE_OPS_READ].avg = 69;
orig_cfg.buckets[THROTTLE_OPS_WRITE].avg = 23;
- orig_cfg.buckets[THROTTLE_BPS_TOTAL].max = 0; /* should be corrected */
- orig_cfg.buckets[THROTTLE_BPS_READ].max = 1; /* should not be corrected */
+ orig_cfg.buckets[THROTTLE_BPS_TOTAL].max = 0; /* should be corrected */
+ orig_cfg.buckets[THROTTLE_BPS_READ].max = 56; /* should not be corrected
*/
orig_cfg.buckets[THROTTLE_BPS_WRITE].max = 120;
orig_cfg.buckets[THROTTLE_OPS_TOTAL].max = 150;
@@ -246,8 +246,8 @@ static void test_config_functions(void)
g_assert(final_cfg.buckets[THROTTLE_OPS_READ].avg == 69);
g_assert(final_cfg.buckets[THROTTLE_OPS_WRITE].avg == 23);
- g_assert(final_cfg.buckets[THROTTLE_BPS_TOTAL].max == 15.3);/* fixed */
- g_assert(final_cfg.buckets[THROTTLE_BPS_READ].max == 1); /* not fixed */
+ g_assert(final_cfg.buckets[THROTTLE_BPS_TOTAL].max == 15.3); /* fixed */
+ g_assert(final_cfg.buckets[THROTTLE_BPS_READ].max == 56); /* not fixed
*/
g_assert(final_cfg.buckets[THROTTLE_BPS_WRITE].max == 120);
g_assert(final_cfg.buckets[THROTTLE_OPS_TOTAL].max == 150);
--
2.9.3
- [Qemu-devel] [PULL for-2.9 0/6] Block patches, Stefan Hajnoczi, 2017/04/21
- [Qemu-devel] [PULL for-2.9 1/6] qemu-options: explain disk I/O throttling options, Stefan Hajnoczi, 2017/04/21
- [Qemu-devel] [PULL for-2.9 2/6] throttle: do not use invalid config in test,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL for-2.9 3/6] throttle: make throttle_config(throttle_get_config()) symmetric, Stefan Hajnoczi, 2017/04/21
- [Qemu-devel] [PULL for-2.9 4/6] migration/block: use blk_pwrite_zeroes for each zero cluster, Stefan Hajnoczi, 2017/04/21
- [Qemu-devel] [PULL for-2.9 5/6] MAINTAINERS: update Wen's email address, Stefan Hajnoczi, 2017/04/21
- [Qemu-devel] [PULL for-2.9 6/6] MAINTAINERS: update my email address, Stefan Hajnoczi, 2017/04/21
- Re: [Qemu-devel] [PULL for-2.9 0/6] Block patches, Peter Maydell, 2017/04/21
- Re: [Qemu-devel] [PULL for-2.9 0/6] Block patches, Eric Blake, 2017/04/21