[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors |
Date: |
Mon, 24 Apr 2017 10:53:32 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 04/24/2017 10:47 AM, Eric Blake wrote:
> On 04/24/2017 10:37 AM, Philippe Mathieu-Daudé wrote:
>
>>>> /*
>>>> - * Returns true iff the first sector pointed to by 'buf' contains at
>>>> least
>>>> - * a non-NUL byte.
>>>> + * Returns true if the first sector pointed to by 'buf' contains at
>>>> least
>>>> + * a non-NULL byte.
>>>
>>> NACK to both changes. 'iff' is an English word that is shorthand for
>>> "if and only if". "NUL" means the one-byte character, while "NULL"
>>> means the 8-byte (or 4-byte, on 32-bit platform) pointer value.
>>
>> I agree with Lidong shorthands are not obvious from non-native speaker.
>>
>> What about this?
>>
>> * Returns true if (and only if) the first sector pointed to by 'buf'
>> contains
>
> That might be okay.
>
>> * at least a non-null character.
>
> But that still doesn't make sense. The character name is NUL, and
> non-NULL refers to something that is a pointer, not a character.
What's more, the NUL character can actually occupy more than one byte
(think UTF-16, where it is the two-byte 0 value). Referring to NUL byte
rather than NUL character (or even the 'zero byte') makes it obvious
that this function is NOT encoding-sensitive, and doesn't start
mis-behaving just because the data picks a multi-byte character encoding.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 1/2] qemu-img: make sure contain the consecutive number of zero bytes, jemmy858585, 2017/04/23
- [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors, jemmy858585, 2017/04/23
- Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors, Eric Blake, 2017/04/24
- Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors, Philippe Mathieu-Daudé, 2017/04/24
- Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors, Eric Blake, 2017/04/24
- Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors, 858585 jemmy, 2017/04/24
- Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors, Max Reitz, 2017/04/25
- Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors, 858585 jemmy, 2017/04/26
Re: [Qemu-devel] [PATCH 1/2] qemu-img: make sure contain the consecutive number of zero bytes, Eric Blake, 2017/04/24