Re: [Qemu-devel] [PATCH RESEND v2 04/18] COLO: integrate colo compare with colo frame

[Juan Quintela]

zhanghailiang <address@hidden> wrote:
> For COLO FT, both the PVM and SVM run at the same time,
> only sync the state while it needs.
>
> So here, let SVM runs while not doing checkpoint, change
> DEFAULT_MIGRATE_X_CHECKPOINT_DELAY to 200*100.
>
> Besides, we forgot to release colo_checkpoint_semd and
> colo_delay_timer, fix them here.
>
> Cc: Jason Wang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>

....

> diff --git a/migration/migration.c b/migration/migration.c
> index 353f272..2ade2aa 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -70,7 +70,7 @@
>  /* The delay time (in ms) between two COLO checkpoints
>   * Note: Please change this default value to 10000 when we support hybrid 
> mode.
>   */
> -#define DEFAULT_MIGRATE_X_CHECKPOINT_DELAY 200
> +#define DEFAULT_MIGRATE_X_CHECKPOINT_DELAY (200 * 100)
>  
>  static NotifierList migration_state_notifiers =
>      NOTIFIER_LIST_INITIALIZER(migration_state_notifiers);

1000 or 200 * 100

Please, fix value or comment?

Later, Juan.