[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [QEMU-2.8] Source QEMU crashes with: "bdrv_co_pwritev:

From: Hailiang Zhang
Subject: Re: [Qemu-devel] [QEMU-2.8] Source QEMU crashes with: "bdrv_co_pwritev: Assertion `!(bs->open_flags & BDRV_O_INACTIVE)' failed"
Date: Tue, 25 Apr 2017 15:58:19 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 2017/4/24 15:59, Kashyap Chamarthy wrote:
On Sat, Apr 22, 2017 at 05:23:49PM +0800, Hailiang Zhang wrote:
Hi Hailiang,

I think the bellow patch can fix your problme.
[PATCH 2/4] qmp-cont: invalidate on RUN_STATE_PRELAUNCH
Hmm, the above patch ("qmp-cont: invalidate on RUN_STATE_PRELAUNCH") is
not merged in Git, as it's stalled on design discussion between Kevin
Wolf and Vladimir.

And the below patch, from you, seems to be not submitted upstream (2.8
stable tree, perhaps).  Do you intend to do so?

Er, since this patch does the same thing with the above patch, I'm not sure if 
i should
send this patch ...

Actually, we encounter the same problem in our test, we fix it with the follow 

      From 0e4d6d706afd9909b5fd71536b45c58af60892f8 Mon Sep 17 00:00:00 2001
      From: zhanghailiang<address@hidden>
      Date: Tue, 21 Mar 2017 09:44:36 +0800
      Subject: [PATCH] migration: Re-activate blocks whenever migration been

      In commit 1d2acc3162d9c7772510c973f446353fbdd1f9a8, we try to fix the bug
      'bdrv_co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed'
      which occured in migration cancelling process.

      But it seems that we didn't cover all the cases, we caught such a case 
      slipped from the old fixup in our test: if libvirtd cancelled the 
      process for a shutting down VM, it will send 'system_reset' command first,
      and then 'cont' command behind, after VM resumes to run, it will trigger 
the above
      error reports, because we didn't regain the control of blocks for VM.

      Signed-off-by: zhanghailiang<address@hidden>
      Signed-off-by: Hongyang Yang<address@hidden>
       block.c                       | 12 +++++++++++-
       include/block/block.h         |  1 +
       include/migration/migration.h |  3 ---
       migration/migration.c         |  7 +------
       qmp.c                         |  4 +---
       5 files changed, 14 insertions(+), 13 deletions(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]