[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-devel RFC v2 4/4] msf2: Add Emcraft's Smartfusion
Re: [Qemu-devel] [Qemu-devel RFC v2 4/4] msf2: Add Emcraft's Smartfusion2 SOM kit.
Tue, 25 Apr 2017 15:34:57 +0530
On Mon, Apr 24, 2017 at 11:23 PM, Alistair Francis <address@hidden> wrote:
>>> Instead of calling all of these in the init function you should split
>>> it up over the machines init and realize function.
>>> Look at the stm32f205_soc or xlnx-zynqmp files for examples of how to do
>>> It also moves away from calling qdev_create() and qdev_init_nofail()
>>> and instead manually creates the objects.
>> I am still learning all these. Please correct me if am wrong.
>> I need to create a SoC file and a board file like stm32f205 and
>> xlnx-zynqmp now right?
> Hey Sundeep,
> I don't think you have to do it like that. I think for some
> SoCs/boards it makes sense. For example the ZynqMP SoCs are included
> on multiple different boards (EP108 and ZCU102) so it makes sense to
> have a SoC and a board separately defined. On the other hand if you
> had a SoC that is always on the same board it doesn't make as much
> It is probably is a good idea to split it between a board and an SoC
> unless you have a good reason not to though.
There are multiples boards with the SoC. I will split into seperate files.
>>> Otherwise this patch looks pretty good.
>> Thank you :)
>>>> +static void msf2_machine_init(MachineClass *mc)
>>>> + mc->desc = "SmartFusion2 SOM kit from Emcraft";
>>>> + mc->init = msf2_init;
>>>> +DEFINE_MACHINE("smartfusion2-som", msf2_machine_init)
Re: [Qemu-devel] [Qemu-devel RFC v2 0/4] Add support for Smartfusion2 SoC, sundeep subbaraya, 2017/04/12
- Re: [Qemu-devel] [Qemu-devel RFC v2 1/4] msf2: Add Smartfusion2 System timer, (continued)