[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] monitor: Move hmp_savevm from savevm.c to h
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] monitor: Move hmp_savevm from savevm.c to hmp.c |
Date: |
Tue, 25 Apr 2017 15:33:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 25/04/2017 12:24, Juan Quintela wrote:
> It is a monitor command, and has nothing migration specific in it.
>
> Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
> ---
> hmp.c | 5 +++++
> hmp.h | 1 +
> include/sysemu/sysemu.h | 1 -
> migration/savevm.c | 5 -----
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hmp.c b/hmp.c
> index f6b8738..a82a952 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1281,6 +1281,11 @@ void hmp_loadvm(Monitor *mon, const QDict *qdict)
> }
> }
>
> +void hmp_savevm(Monitor *mon, const QDict *qdict)
> +{
> + save_vmstate(qdict_get_try_str(qdict, "name"));
> +}
> +
> void hmp_migrate_cancel(Monitor *mon, const QDict *qdict)
> {
> qmp_migrate_cancel(NULL);
> diff --git a/hmp.h b/hmp.h
> index 385332c..b302c8d 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -64,6 +64,7 @@ void hmp_snapshot_delete_blkdev_internal(Monitor *mon,
> const QDict *qdict);
> void hmp_drive_mirror(Monitor *mon, const QDict *qdict);
> void hmp_drive_backup(Monitor *mon, const QDict *qdict);
> void hmp_loadvm(Monitor *mon, const QDict *qdict);
> +void hmp_savevm(Monitor *mon, const QDict *qdict);
> void hmp_migrate_cancel(Monitor *mon, const QDict *qdict);
> void hmp_migrate_incoming(Monitor *mon, const QDict *qdict);
> void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict);
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index b6daf9d..914c36c 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -75,7 +75,6 @@ void qemu_remove_exit_notifier(Notifier *notify);
> void qemu_add_machine_init_done_notifier(Notifier *notify);
> void qemu_remove_machine_init_done_notifier(Notifier *notify);
>
> -void hmp_savevm(Monitor *mon, const QDict *qdict);
> int save_vmstate(const char *name);
> int load_vmstate(const char *name);
> void hmp_delvm(Monitor *mon, const QDict *qdict);
> diff --git a/migration/savevm.c b/migration/savevm.c
> index ff934aa..bbff4d8 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -2171,11 +2171,6 @@ int save_vmstate(const char *name)
> return ret;
> }
>
> -void hmp_savevm(Monitor *mon, const QDict *qdict)
> -{
> - save_vmstate(qdict_get_try_str(qdict, "name"));
> -}
> -
> void qmp_xen_save_devices_state(const char *filename, Error **errp)
> {
> QEMUFile *f;
>
- [Qemu-devel] [PATCH 2/6] monitor: Move hmp_loadvm from monitor.c to hmp.c, (continued)
- [Qemu-devel] [PATCH 2/6] monitor: Move hmp_loadvm from monitor.c to hmp.c, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 1/6] monitor: Remove monitor parameter from save_vmstate, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 4/6] monitor: Move hmp_delvm from savevm.c to hmp.c, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 5/6] monitor: Move hmp_info_snapshots from savevm.c to hmp.c, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 3/6] monitor: Move hmp_savevm from savevm.c to hmp.c, Juan Quintela, 2017/04/25
- Re: [Qemu-devel] [PATCH 3/6] monitor: Move hmp_savevm from savevm.c to hmp.c,
Laurent Vivier <=
- [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate, Juan Quintela, 2017/04/25
- Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate, Dr. David Alan Gilbert, 2017/04/28
- Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate, Eric Blake, 2017/04/28
Re: [Qemu-devel] [PATCH 0/6] Move snapshots commands to hmp, Dr. David Alan Gilbert, 2017/04/28