[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/26] Audio Cleanup
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 00/26] Audio Cleanup |
Date: |
Tue, 25 Apr 2017 16:31:47 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/26] Audio Cleanup
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
426bc46 audio: Use ARRAY_SIZE from qemu/osdep.h
67f41a4 audio: un-export OPLResetChip
2928139 audio: Remove unused typedefs
c5bed44 audio: UpdateHandler is not used anymore
0f97e4e audio: IRQHandler is not used anymore
9be6fbb audio: OPLSetUpdateHandler is not used anywhere
17d4a87 audio: OPLSetIRQHandler is not used anywhere
331f9f0 audio: GUSsample is int16_t
eb7522b audio: GUSword is uint16_t
b6db066 audio: GUSword is uint16_t
4f2e7e5 audio: remove GUSchar
430732c audio: GUSbyte is uint8_t
5494808 audio: Remove unused fields
2f74da9 audio: Remove type field
91ee28c audio: Remove Unused OPL_TYPE_*
54a318a audio: Unfold OPLSAMPLE
ca7aa23 audio: Remove INT32
237513a audio: remove INT16
975980b audio: Remove INT8
1b97e08 audio: remove UINT32
7beb767 audio: remove UINT16
6699511 audio: Remove UINT8
4e01d17 audio: YM3812 was always defined
decafab audio: Remove YM3526 support
9ee2738 audio: remove Y8950 configuration
b24fc9b adlib: Remove support for YMF262
=== OUTPUT BEGIN ===
Checking PATCH 1/26: adlib: Remove support for YMF262...
Checking PATCH 2/26: audio: remove Y8950 configuration...
Checking PATCH 3/26: audio: Remove YM3526 support...
Checking PATCH 4/26: audio: YM3812 was always defined...
Checking PATCH 5/26: audio: Remove UINT8...
ERROR: code indent should never use tabs
#21: FILE: hw/audio/fmopl.c:792:
+^I^I^I^Iuint8_t st1 = v&1;$
ERROR: spaces required around that '&' (ctx:VxV)
#21: FILE: hw/audio/fmopl.c:792:
+ uint8_t st1 = v&1;
^
ERROR: code indent should never use tabs
#22: FILE: hw/audio/fmopl.c:793:
+^I^I^I^Iuint8_t st2 = (v>>1)&1;$
ERROR: spaces required around that '>>' (ctx:VxV)
#22: FILE: hw/audio/fmopl.c:793:
+ uint8_t st2 = (v>>1)&1;
^
ERROR: spaces required around that '&' (ctx:VxV)
#22: FILE: hw/audio/fmopl.c:793:
+ uint8_t st2 = (v>>1)&1;
^
ERROR: code indent should never use tabs
#31: FILE: hw/audio/fmopl.c:841:
+^I^I^Iuint8_t rkey = OPL->rhythm^v;$
ERROR: spaces required around that '^' (ctx:VxV)
#31: FILE: hw/audio/fmopl.c:841:
+ uint8_t rkey = OPL->rhythm^v;
^
ERROR: code indent should never use tabs
#40: FILE: hw/audio/fmopl.c:994:
+^Iuint8_t rhythm = OPL->rhythm&0x20;$
ERROR: spaces required around that '&' (ctx:VxV)
#40: FILE: hw/audio/fmopl.c:994:
+ uint8_t rhythm = OPL->rhythm&0x20;
^
ERROR: code indent should never use tabs
#70: FILE: hw/audio/fmopl.h:45:
+^Iuint8_t KSR;^I^I/* key scale rate :(shift down bit) */$
ERROR: code indent should never use tabs
#77: FILE: hw/audio/fmopl.h:50:
+^Iuint8_t ksl;^I^I/* keyscale level :(shift down bits) */$
ERROR: code indent should never use tabs
#78: FILE: hw/audio/fmopl.h:51:
+^Iuint8_t ksr;^I^I/* key scale rate :kcode>>KSR */$
ERROR: code indent should never use tabs
#85: FILE: hw/audio/fmopl.h:56:
+^Iuint8_t eg_typ;^I/* envelope type flag */$
ERROR: code indent should never use tabs
#86: FILE: hw/audio/fmopl.h:57:
+^Iuint8_t evm;^I^I/* envelope phase */$
ERROR: code indent should never use tabs
#96: FILE: hw/audio/fmopl.h:65:
+^Iuint8_t ams;^I^I/* ams flag */$
ERROR: code indent should never use tabs
#97: FILE: hw/audio/fmopl.h:66:
+^Iuint8_t vib;^I^I/* vibrate flag */$
WARNING: line over 80 characters
#107: FILE: hw/audio/fmopl.h:74:
+ uint8_t CON; /* connection type
*/
ERROR: code indent should never use tabs
#107: FILE: hw/audio/fmopl.h:74:
+^Iuint8_t CON;^I^I^I/* connection type */$
WARNING: line over 80 characters
#108: FILE: hw/audio/fmopl.h:75:
+ uint8_t FB; /* feed back :(shift down bit)
*/
ERROR: code indent should never use tabs
#108: FILE: hw/audio/fmopl.h:75:
+^Iuint8_t FB;^I^I^I/* feed back :(shift down bit) */$
ERROR: code indent should never use tabs
#115: FILE: hw/audio/fmopl.h:81:
+^Iuint8_t kcode;^I^I/* key code : KeyScaleCode */$
ERROR: code indent should never use tabs
#119: FILE: hw/audio/fmopl.h:84:
+^Iuint8_t keyon;^I^I/* key on/off flag */$
ERROR: code indent should never use tabs
#125: FILE: hw/audio/fmopl.h:89:
+^Iuint8_t type;^I^I^I/* chip type */$
ERROR: code indent should never use tabs
#133: FILE: hw/audio/fmopl.h:94:
+^Iuint8_t address;^I^I/* address register */$
ERROR: code indent should never use tabs
#134: FILE: hw/audio/fmopl.h:95:
+^Iuint8_t status;^I^I/* status flag */$
ERROR: code indent should never use tabs
#135: FILE: hw/audio/fmopl.h:96:
+^Iuint8_t statusmask;^I/* status mask */$
ERROR: code indent should never use tabs
#140: FILE: hw/audio/fmopl.h:100:
+^Iuint8_t st[2];^I^I/* timer enable */$
ERROR: code indent should never use tabs
#146: FILE: hw/audio/fmopl.h:105:
+^Iuint8_t rhythm;^I^I/* Rhythm mode , key flag */$
ERROR: code indent should never use tabs
#155: FILE: hw/audio/fmopl.h:124:
+^Iuint8_t wavesel;$
total: 27 errors, 2 warnings, 131 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/26: audio: remove UINT16...
Checking PATCH 7/26: audio: remove UINT32...
ERROR: spaces required around that '*' (ctx:VxV)
#18: FILE: hw/audio/fmopl.c:125:
+static const uint32_t KSL_TABLE[8*16]=
^
ERROR: spaces required around that '=' (ctx:VxE)
#18: FILE: hw/audio/fmopl.c:125:
+static const uint32_t KSL_TABLE[8*16]=
^
ERROR: spaces required around that '=' (ctx:VxW)
#27: FILE: hw/audio/fmopl.c:198:
+static const uint32_t MUL_TABLE[16]= {
^
ERROR: spaces required around that '*' (ctx:WxV)
#36: FILE: hw/audio/fmopl.c:322:
+static inline uint32_t OPL_CALC_SLOT( OPL_SLOT *SLOT )
^
ERROR: space prohibited after that open parenthesis '('
#36: FILE: hw/audio/fmopl.c:322:
+static inline uint32_t OPL_CALC_SLOT( OPL_SLOT *SLOT )
ERROR: space prohibited before that close parenthesis ')'
#36: FILE: hw/audio/fmopl.c:322:
+static inline uint32_t OPL_CALC_SLOT( OPL_SLOT *SLOT )
ERROR: code indent should never use tabs
#45: FILE: hw/audio/fmopl.c:454:
+^Iuint32_t env_out;$
ERROR: code indent should never use tabs
#54: FILE: hw/audio/fmopl.c:499:
+^Iuint32_t env_tam,env_sd,env_top,env_hh;$
ERROR: space required after that ',' (ctx:VxV)
#54: FILE: hw/audio/fmopl.c:499:
+ uint32_t env_tam,env_sd,env_top,env_hh;
^
ERROR: space required after that ',' (ctx:VxV)
#54: FILE: hw/audio/fmopl.c:499:
+ uint32_t env_tam,env_sd,env_top,env_hh;
^
ERROR: space required after that ',' (ctx:VxV)
#54: FILE: hw/audio/fmopl.c:499:
+ uint32_t env_tam,env_sd,env_top,env_hh;
^
ERROR: code indent should never use tabs
#64: FILE: hw/audio/fmopl.c:992:
+^Iuint32_t amsCnt = OPL->amsCnt;$
ERROR: code indent should never use tabs
#65: FILE: hw/audio/fmopl.c:993:
+^Iuint32_t vibCnt = OPL->vibCnt;$
ERROR: code indent should never use tabs
#88: FILE: hw/audio/fmopl.h:50:
+^Iuint32_t mul;^I^I/* multiple :ML_TABLE[ML] */$
ERROR: code indent should never use tabs
#89: FILE: hw/audio/fmopl.h:51:
+^Iuint32_t Cnt;^I^I/* frequency count : */$
ERROR: code indent should never use tabs
#90: FILE: hw/audio/fmopl.h:52:
+^Iuint32_t Incr;^I/* frequency step : */$
ERROR: code indent should never use tabs
#99: FILE: hw/audio/fmopl.h:78:
+^Iuint32_t block_fnum;^I/* block+fnum : */$
WARNING: line over 80 characters
#103: FILE: hw/audio/fmopl.h:80:
+ uint32_t fc; /* Freq. Increment base
*/
ERROR: code indent should never use tabs
#103: FILE: hw/audio/fmopl.h:80:
+^Iuint32_t fc;^I^I^I/* Freq. Increment base */$
ERROR: code indent should never use tabs
#104: FILE: hw/audio/fmopl.h:81:
+^Iuint32_t ksl_base;^I/* KeyScaleLevel Base step */$
ERROR: code indent should never use tabs
#113: FILE: hw/audio/fmopl.h:95:
+^Iuint32_t mode;^I^I/* Reg.08 : CSM , notesel,etc. */$
ERROR: code indent should never use tabs
#122: FILE: hw/audio/fmopl.h:113:
+^Iuint32_t FN_TABLE[1024]; /* fnumber -> increment counter */$
total: 21 errors, 1 warnings, 98 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/26: audio: Remove INT8...
Checking PATCH 9/26: audio: remove INT16...
Checking PATCH 10/26: audio: Remove INT32...
ERROR: spaces required around that '=' (ctx:VxV)
#18: FILE: hw/audio/fmopl.c:173:
+static const int32_t SL_TABLE[16]={
^
ERROR: spaces required around that '*' (ctx:VxV)
#42: FILE: hw/audio/fmopl.c:194:
+static int32_t ENV_CURVE[2*EG_ENT+1];
^
ERROR: spaces required around that '+' (ctx:VxV)
#42: FILE: hw/audio/fmopl.c:194:
+static int32_t ENV_CURVE[2*EG_ENT+1];
^
ERROR: spaces required around that '=' (ctx:VxE)
#51: FILE: hw/audio/fmopl.c:206:
+static int32_t RATE_0[16]=
^
ERROR: code indent should never use tabs
#74: FILE: hw/audio/fmopl.c:229:
+static int32_t feedback2;^I^I/* connect for SLOT 2 */$
ERROR: code indent should never use tabs
#83: FILE: hw/audio/fmopl.c:362:
+^Iint32_t *carrier = &outd[0];$
ERROR: code indent should never use tabs
#92: FILE: hw/audio/fmopl.c:501:
+^Iint32_t tone8;$
ERROR: code indent should never use tabs
#101: FILE: hw/audio/fmopl.c:619:
+^Iif( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)$
ERROR: spaces required around that '*' (ctx:VxV)
#101: FILE: hw/audio/fmopl.c:619:
+ if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)
^
ERROR: spaces required around that '*' (ctx:VxV)
#101: FILE: hw/audio/fmopl.c:619:
+ if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)
^
ERROR: space prohibited after that open parenthesis '('
#101: FILE: hw/audio/fmopl.c:619:
+ if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)
ERROR: space required before the open parenthesis '('
#101: FILE: hw/audio/fmopl.c:619:
+ if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)
ERROR: do not use assignment in if condition
#101: FILE: hw/audio/fmopl.c:619:
+ if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)
ERROR: braces {} are necessary for all arms of this statement
#101: FILE: hw/audio/fmopl.c:619:
+ if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)
[...]
ERROR: code indent should never use tabs
#104: FILE: hw/audio/fmopl.c:621:
+^Iif( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)$
ERROR: spaces required around that '*' (ctx:VxV)
#104: FILE: hw/audio/fmopl.c:621:
+ if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)
^
ERROR: spaces required around that '*' (ctx:WxV)
#104: FILE: hw/audio/fmopl.c:621:
+ if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)
^
ERROR: space prohibited after that open parenthesis '('
#104: FILE: hw/audio/fmopl.c:621:
+ if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)
ERROR: space required before the open parenthesis '('
#104: FILE: hw/audio/fmopl.c:621:
+ if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)
ERROR: do not use assignment in if condition
#104: FILE: hw/audio/fmopl.c:621:
+ if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)
ERROR: code indent should never use tabs
#110: FILE: hw/audio/fmopl.c:626:
+^Iif( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)$
ERROR: spaces required around that '*' (ctx:VxV)
#110: FILE: hw/audio/fmopl.c:626:
+ if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)
^
ERROR: spaces required around that '*' (ctx:WxV)
#110: FILE: hw/audio/fmopl.c:626:
+ if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)
^
ERROR: space prohibited after that open parenthesis '('
#110: FILE: hw/audio/fmopl.c:626:
+ if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)
ERROR: space required before the open parenthesis '('
#110: FILE: hw/audio/fmopl.c:626:
+ if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)
ERROR: do not use assignment in if condition
#110: FILE: hw/audio/fmopl.c:626:
+ if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)
ERROR: code indent should never use tabs
#117: FILE: hw/audio/fmopl.c:632:
+^Iif( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)$
ERROR: spaces required around that '*' (ctx:VxV)
#117: FILE: hw/audio/fmopl.c:632:
+ if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)
^
ERROR: spaces required around that '*' (ctx:WxV)
#117: FILE: hw/audio/fmopl.c:632:
+ if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)
^
ERROR: space prohibited after that open parenthesis '('
#117: FILE: hw/audio/fmopl.c:632:
+ if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)
ERROR: space required before the open parenthesis '('
#117: FILE: hw/audio/fmopl.c:632:
+ if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)
ERROR: do not use assignment in if condition
#117: FILE: hw/audio/fmopl.c:632:
+ if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)
ERROR: code indent should never use tabs
#144: FILE: hw/audio/fmopl.h:33:
+^Iint32_t TL;^I^I/* total level :TL << 8 */$
ERROR: code indent should never use tabs
#145: FILE: hw/audio/fmopl.h:34:
+^Iint32_t TLL;^I^I/* adjusted now TL */$
ERROR: code indent should never use tabs
#151: FILE: hw/audio/fmopl.h:36:
+^Iint32_t *AR;^I^I/* attack rate :&AR_TABLE[AR<<2] */$
ERROR: code indent should never use tabs
#152: FILE: hw/audio/fmopl.h:37:
+^Iint32_t *DR;^I^I/* decay rate :&DR_TALBE[DR<<2] */$
ERROR: code indent should never use tabs
#153: FILE: hw/audio/fmopl.h:38:
+^Iint32_t SL;^I^I/* sustin level :SL_TALBE[SL] */$
ERROR: code indent should never use tabs
#154: FILE: hw/audio/fmopl.h:39:
+^Iint32_t *RR;^I^I/* release rate :&DR_TABLE[RR<<2] */$
ERROR: code indent should never use tabs
#168: FILE: hw/audio/fmopl.h:48:
+^Iint32_t evc;^I^I/* envelope counter */$
ERROR: code indent should never use tabs
#169: FILE: hw/audio/fmopl.h:49:
+^Iint32_t eve;^I^I/* envelope counter end point */$
ERROR: code indent should never use tabs
#170: FILE: hw/audio/fmopl.h:50:
+^Iint32_t evs;^I^I/* envelope counter step */$
ERROR: code indent should never use tabs
#171: FILE: hw/audio/fmopl.h:51:
+^Iint32_t evsa;^I/* envelope step for AR :AR[ksr] */$
ERROR: code indent should never use tabs
#172: FILE: hw/audio/fmopl.h:52:
+^Iint32_t evsd;^I/* envelope step for DR :DR[ksr] */$
ERROR: code indent should never use tabs
#173: FILE: hw/audio/fmopl.h:53:
+^Iint32_t evsr;^I/* envelope step for RR :RR[ksr] */$
ERROR: code indent should never use tabs
#179: FILE: hw/audio/fmopl.h:58:
+^Iint32_t **wavetable;$
ERROR: code indent should never use tabs
#190: FILE: hw/audio/fmopl.h:66:
+^Iint32_t *connect1;^I/* slot1 output pointer */$
ERROR: code indent should never use tabs
#191: FILE: hw/audio/fmopl.h:67:
+^Iint32_t *connect2;^I/* slot2 output pointer */$
ERROR: code indent should never use tabs
#192: FILE: hw/audio/fmopl.h:68:
+^Iint32_t op1_out[2];^I/* slot1 output for selfeedback */$
ERROR: code indent should never use tabs
#202: FILE: hw/audio/fmopl.h:103:
+^Iint32_t AR_TABLE[75];^I/* atttack rate tables */$
ERROR: code indent should never use tabs
#203: FILE: hw/audio/fmopl.h:104:
+^Iint32_t DR_TABLE[75];^I/* decay rate tables */$
ERROR: code indent should never use tabs
#212: FILE: hw/audio/fmopl.h:107:
+^Iint32_t *ams_table;$
ERROR: code indent should never use tabs
#213: FILE: hw/audio/fmopl.h:108:
+^Iint32_t *vib_table;$
ERROR: code indent should never use tabs
#214: FILE: hw/audio/fmopl.h:109:
+^Iint32_t amsCnt;$
ERROR: code indent should never use tabs
#215: FILE: hw/audio/fmopl.h:110:
+^Iint32_t amsIncr;$
ERROR: code indent should never use tabs
#216: FILE: hw/audio/fmopl.h:111:
+^Iint32_t vibCnt;$
ERROR: code indent should never use tabs
#217: FILE: hw/audio/fmopl.h:112:
+^Iint32_t vibIncr;$
total: 56 errors, 0 warnings, 192 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/26: audio: Unfold OPLSAMPLE...
ERROR: code indent should never use tabs
#20: FILE: hw/audio/fmopl.c:991:
+^Iint16_t *buf = buffer;$
total: 1 errors, 0 warnings, 25 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/26: audio: Remove Unused OPL_TYPE_*...
Checking PATCH 13/26: audio: Remove type field...
ERROR: code indent should never use tabs
#33: FILE: hw/audio/fmopl.c:764:
+^I^I^IOPL->wavesel = v&0x20;$
ERROR: spaces required around that '&' (ctx:VxV)
#33: FILE: hw/audio/fmopl.c:764:
+ OPL->wavesel = v&0x20;
^
ERROR: space required before the open parenthesis '('
#34: FILE: hw/audio/fmopl.c:765:
+ if(!OPL->wavesel)
ERROR: code indent should never use tabs
#38: FILE: hw/audio/fmopl.c:767:
+^I^I^I^I/* preset compatible mode */$
ERROR: code indent should never use tabs
#39: FILE: hw/audio/fmopl.c:768:
+^I^I^I^Iint c;$
ERROR: code indent should never use tabs
#40: FILE: hw/audio/fmopl.c:769:
+^I^I^I^Ifor(c=0;c<OPL->max_ch;c++)$
ERROR: spaces required around that '=' (ctx:VxV)
#40: FILE: hw/audio/fmopl.c:769:
+ for(c=0;c<OPL->max_ch;c++)
^
ERROR: space required after that ';' (ctx:VxV)
#40: FILE: hw/audio/fmopl.c:769:
+ for(c=0;c<OPL->max_ch;c++)
^
ERROR: spaces required around that '<' (ctx:VxV)
#40: FILE: hw/audio/fmopl.c:769:
+ for(c=0;c<OPL->max_ch;c++)
^
ERROR: space required after that ';' (ctx:VxV)
#40: FILE: hw/audio/fmopl.c:769:
+ for(c=0;c<OPL->max_ch;c++)
^
ERROR: space required before the open parenthesis '('
#40: FILE: hw/audio/fmopl.c:769:
+ for(c=0;c<OPL->max_ch;c++)
ERROR: line over 90 characters
#49: FILE: hw/audio/fmopl.c:771:
+ OPL->P_CH[c].SLOT[SLOT1].wavetable =
&SIN_TABLE[0];
ERROR: code indent should never use tabs
#49: FILE: hw/audio/fmopl.c:771:
+^I^I^I^I^IOPL->P_CH[c].SLOT[SLOT1].wavetable = &SIN_TABLE[0];$
ERROR: line over 90 characters
#50: FILE: hw/audio/fmopl.c:772:
+ OPL->P_CH[c].SLOT[SLOT2].wavetable =
&SIN_TABLE[0];
ERROR: code indent should never use tabs
#50: FILE: hw/audio/fmopl.c:772:
+^I^I^I^I^IOPL->P_CH[c].SLOT[SLOT2].wavetable = &SIN_TABLE[0];$
total: 15 errors, 0 warnings, 73 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 14/26: audio: Remove unused fields...
Checking PATCH 15/26: audio: GUSbyte is uint8_t...
ERROR: line over 90 characters
#34: FILE: hw/audio/gusemu.h:44:
+ uint8_t *himemaddr; /* 1024*1024 bytes used for storing uploaded samples (+32
additional bytes for read padding) */
ERROR: line over 90 characters
#35: FILE: hw/audio/gusemu.h:45:
+ uint8_t *gusdatapos; /* (gusdataend-gusdata) bytes used for storing emulated
GF1/mixer register states (32*32+4 bytes in initial GUSemu32 version) */
WARNING: line over 80 characters
#123: FILE: hw/audio/gusemu_hal.c:241:
+ GUSregb(IRQ_2xB) = (uint8_t) data; /* control register select
bit */
WARNING: line over 80 characters
#162: FILE: hw/audio/gusemu_hal.c:278:
+ if ((uint8_t) data == 0x8f) /* set irqstatreg, get voicereg and clear
IRQ */
ERROR: line over 90 characters
#239: FILE: hw/audio/gusemu_hal.c:525:
+ GUSregb(GUS50DMAHigh) = (uint8_t) ((count + GUSregb(GUS50DMAHigh)) &
0xf); /* ToDo: add 16bit GUS page limit? */
ERROR: space prohibited after that '&' (ctx:WxW)
#239: FILE: hw/audio/gusemu_hal.c:525:
+ GUSregb(GUS50DMAHigh) = (uint8_t) ((count + GUSregb(GUS50DMAHigh)) &
0xf); /* ToDo: add 16bit GUS page limit? */
^
total: 4 errors, 2 warnings, 225 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 16/26: audio: remove GUSchar...
Checking PATCH 17/26: audio: GUSword is uint16_t...
Checking PATCH 18/26: audio: GUSword is uint16_t...
ERROR: spaces required around that '+' (ctx:VxV)
#18: FILE: hw/audio/gusemu_hal.c:34:
+#define GUSregw(position) (*(uint16_t *) (gusptr+(position)))
^
ERROR: line over 90 characters
#55: FILE: hw/audio/gusemu_hal.c:356:
+ GUSregw(offset) = (uint16_t) ((GUSregw(offset) & readmask)
| writedata);
ERROR: line over 90 characters
#64: FILE: hw/audio/gusemu_hal.c:524:
+ GUSregw(GUS42DMAStart) += (uint16_t) (count >> 4);
/* ToDo: add 16bit GUS page limit? */
ERROR: spaces required around that '+' (ctx:VxV)
#77: FILE: hw/audio/gusemu_mixer.c:30:
+#define GUSregw(position) (*(uint16_t *) (gusptr+(position)))
^
ERROR: spaces required around that '+' (ctx:VxV)
#81: FILE: hw/audio/gusemu_mixer.c:33:
+#define GUSvoice(position) (*(uint16_t *)(voiceptr+(position)))
^
total: 5 errors, 0 warnings, 78 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 19/26: audio: GUSsample is int16_t...
ERROR: line over 90 characters
#48: FILE: hw/audio/gusemu.h:79:
+void gus_mixvoices(GUSEmuState *state, unsigned int playback_freq, unsigned
int numsamples, int16_t *bufferpos);
ERROR: spaces required around that '+' (ctx:VxV)
#61: FILE: hw/audio/gusemu_hal.c:35:
+#define GUSregd(position) (*(uint16_t *)(gusptr+(position)))
^
ERROR: spaces required around that '+' (ctx:VxV)
#74: FILE: hw/audio/gusemu_mixer.c:31:
+#define GUSregd(position) (*(uint16_t *)(gusptr+(position)))
^
ERROR: line over 90 characters
#91: FILE: hw/audio/gusemu_mixer.c:174:
+ *(bufferpos + 2 * sample) += (int16_t) ((sample1 *
PanningPos) >> 4); /* right */
ERROR: line over 90 characters
#92: FILE: hw/audio/gusemu_mixer.c:175:
+ *(bufferpos + 2 * sample + 1) += (int16_t) ((sample1 * (15 -
PanningPos)) >> 4); /* left */
total: 5 errors, 0 warnings, 65 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 20/26: audio: OPLSetIRQHandler is not used anywhere...
Checking PATCH 21/26: audio: OPLSetUpdateHandler is not used anywhere...
Checking PATCH 22/26: audio: IRQHandler is not used anymore...
Checking PATCH 23/26: audio: UpdateHandler is not used anymore...
Checking PATCH 24/26: audio: Remove unused typedefs...
Checking PATCH 25/26: audio: un-export OPLResetChip...
Checking PATCH 26/26: audio: Use ARRAY_SIZE from qemu/osdep.h...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-devel] [PATCH 19/26] audio: GUSsample is int16_t, (continued)
- [Qemu-devel] [PATCH 20/26] audio: OPLSetIRQHandler is not used anywhere, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 22/26] audio: IRQHandler is not used anymore, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 21/26] audio: OPLSetUpdateHandler is not used anywhere, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 23/26] audio: UpdateHandler is not used anymore, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 24/26] audio: Remove unused typedefs, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 25/26] audio: un-export OPLResetChip, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 26/26] audio: Use ARRAY_SIZE from qemu/osdep.h, Juan Quintela, 2017/04/25
- Re: [Qemu-devel] [PATCH 00/26] Audio Cleanup,
no-reply <=
- Re: [Qemu-devel] [PATCH 00/26] Audio Cleanup, Juan Quintela, 2017/04/26