[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/26] audio: Remove UINT8
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 05/26] audio: Remove UINT8 |
Date: |
Wed, 26 Apr 2017 09:22:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> wrote:
> Hi Juan,
>
> On 04/25/2017 07:37 PM, Juan Quintela wrote:
>> uint8_t has existed since ..... all this century?
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> hw/audio/fmopl.c | 8 ++++----
>> hw/audio/fmopl.h | 39 ++++++++++++++++++++-------------------
>> 2 files changed, 24 insertions(+), 23 deletions(-)
>>
>> diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
>> index 282662a..3d14b45 100644
>> --- a/hw/audio/fmopl.c
>> +++ b/hw/audio/fmopl.c
>> @@ -789,8 +789,8 @@ static void OPLWriteReg(FM_OPL *OPL, int r, int v)
>> }
>> else
>> { /* set IRQ mask ,timer enable*/
>> - UINT8 st1 = v&1;
>> - UINT8 st2 = (v>>1)&1;
>> + uint8_t st1 = v&1;
>> + uint8_t st2 = (v>>1)&1;
>
> Welcome to stdint! but since you're changing this code please make it
> more readable (at least spaces) so checkpatch don't reject your serie:
>
> ERROR: spaces required around that '&'
checkpatch reject because there are no spaces and there are tabs all
around. I think that the only sane solution is to run indent on the
whole file, or maintain the "old" format.
Gerd, any prefferences?
Later, Juan.
- [Qemu-devel] [PATCH 00/26] Audio Cleanup, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 01/26] adlib: Remove support for YMF262, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 03/26] audio: Remove YM3526 support, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 02/26] audio: remove Y8950 configuration, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 04/26] audio: YM3812 was always defined, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 05/26] audio: Remove UINT8, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 06/26] audio: remove UINT16, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 07/26] audio: remove UINT32, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 08/26] audio: Remove INT8, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 09/26] audio: remove INT16, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 10/26] audio: Remove INT32, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 11/26] audio: Unfold OPLSAMPLE, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 12/26] audio: Remove Unused OPL_TYPE_*, Juan Quintela, 2017/04/25
- [Qemu-devel] [PATCH 13/26] audio: Remove type field, Juan Quintela, 2017/04/25