Re: [Qemu-devel] [PATCH v2 05/18] COLO: Handle shutdown command for VM in COLO state

[Hailiang Zhang]

On 2017/4/24 22:51, Eric Blake wrote:
> On 04/22/2017 03:25 AM, zhanghailiang wrote:
> > If VM is in COLO FT state, we need to do some extra works before
> > starting normal shutdown process.
> >
> > Secondary VM will ignore the shutdown command if users issue it directly
> > to Secondary VM. COLO will capture shutdown command and after
> > shutdown request from user.
> >
> > Cc: Paolo Bonzini <address@hidden>
> > Signed-off-by: zhanghailiang <address@hidden>
> > Signed-off-by: Li Zhijian <address@hidden>
> > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> > ---
> > +++ b/qapi-schema.json
> > @@ -1187,12 +1187,14 @@
> >   #
> >   # @vmstate-loaded: VM's state has been loaded by SVM.
> >   #
> > +# @guest-shutdown: shutdown requested from PVM to SVM. (Since 2.9)
> You missed 2.9. Please fix this to state 2.10.

OK, will fix in next version, thanks.

> > +#
> >   # Since: 2.8
> >   ##
> >   { 'enum': 'COLOMessage',
> >     'data': [ 'checkpoint-ready', 'checkpoint-request', 'checkpoint-reply',
> >               'vmstate-send', 'vmstate-size', 'vmstate-received',
> > -            'vmstate-loaded' ] }
> > +            'vmstate-loaded', 'guest-shutdown' ] }
> >