Re: [Qemu-devel] [PATCH RFC 1/1] vfio/pci: Fix incorrect error message

[Auger Eric]

Hi Dong,

On 25/04/2017 06:56, Dong Jia Shi wrote:
> * Dong Jia Shi <address@hidden> [2017-04-25 06:52:01 +0200]:
> 
> Hey Alex,
> 
> Please ignore the "RFC" tag in the subject. Sorry for the mistake.
> 
>> When the "No host device provided" error occurs, the hint message
>> that starts with "Use -vfio-pci," makes no sense, since "-vfio-pci"
>> is not a valid command line parameter.
>>
>> Correct this by replacing "-vfio-pci" with "-device vfio-pci".
>>
>> Signed-off-by: Dong Jia Shi <address@hidden>
Reviewed-by: Eric Auger <address@hidden>

Thanks

Eric
>> ---
>>  hw/vfio/pci.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
>> index 03a3d01..32aca77 100644
>> --- a/hw/vfio/pci.c
>> +++ b/hw/vfio/pci.c
>> @@ -2625,8 +2625,8 @@ static void vfio_realize(PCIDevice *pdev, Error **errp)
>>          if (!(~vdev->host.domain || ~vdev->host.bus ||
>>                ~vdev->host.slot || ~vdev->host.function)) {
>>              error_setg(errp, "No provided host device");
>> -            error_append_hint(errp, "Use -vfio-pci,host=DDDD:BB:DD.F "
>> -                              "or -vfio-pci,sysfsdev=PATH_TO_DEVICE\n");
>> +            error_append_hint(errp, "Use -device vfio-pci,host=DDDD:BB:DD.F 
>> "
>> +                              "or -device 
>> vfio-pci,sysfsdev=PATH_TO_DEVICE\n");
>>              return;
>>          }
>>          vdev->vbasedev.sysfsdev =
>> -- 
>> 2.10.2
>>
>