[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] qmp-cont: invalidate on RUN_ST
Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] qmp-cont: invalidate on RUN_STATE_PRELAUNCH
Wed, 26 Apr 2017 16:43:52 +0300
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
26.04.2017 15:22, Kashyap Chamarthy wrote:
On Tue, Mar 07, 2017 at 01:11:23PM +0300, Vladimir Sementsov-Ogievskiy wrote:
07.03.2017 13:02, Kevin Wolf wrote:
Am 25.02.2017 um 20:31 hat Vladimir Sementsov-Ogievskiy geschrieben:
We must invalidate on RUN_STATE_PRELAUNCH too, as it is available
through qmp_system_reset from RUN_STATE_POSTMIGRATE. Otherwise, we will
qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev:
Assertion `!(bs->open_flags & 0x0800)' failed.
on the first write after vm start.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Wouldn't it make more sense to invalidate in qmp_system_reset() where
the migration states are left?
Or maybe BDRV_O_INACTIVE could even be tied directly to runstates? Not
sure how realistic this one is, but if we start adding invalidate_cache
calls all over the place, maybe that's a sign that we need to look for a
more central place.
I've proposed it in cover letter) These bugs and my fixes are just show that
something should be rethought.. I don't claim that these fixes are true way,
they are just the simplest.
I wonder if you have a new version of your patch ("qmp-cont: invalidate
Hailiang Zhang tells me on this the below thread that your patch fixes
-- [QEMU-2.8] Source QEMU crashes with: "bdrv_co_pwritev: Assertion
`!(bs->open_flags & BDRV_O_INACTIVE)' failed"
No, I haven't new version, discussion is unfinished about true way of
doing it. This version is ok with the case it fixes.