[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 07/18] block: deprecate "encryption=on" in fa

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v6 07/18] block: deprecate "encryption=on" in favour of "encrypt.format=aes"
Date: Wed, 26 Apr 2017 09:14:55 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0

On 04/25/2017 10:38 AM, Daniel P. Berrange wrote:
> Historically the qcow & qcow2 image formats supported a property
> "encryption=on" to enable their built-in AES encryption. We'll
> soon be supporting LUKS for qcow2, so need a more general purpose
> way to enable encryption, with a choice of formats.
> This introduces an "encrypt.format" option, which will later be
> joined by a number of other "encrypt.XXX" options. The use of
> a "encrypt." prefix instead of "encrypt-" is done to facilitate
> mapping to a nested QAPI schema at later date.
> e.g. the preferred syntax is now
>   qemu-img create -f qcow2 -o encrypt.format=aes demo.qcow2
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---

> @@ -3370,10 +3385,16 @@ static QemuOptsList qcow2_create_opts = {
>          {
>              .name = BLOCK_OPT_ENCRYPT,
>              .type = QEMU_OPT_BOOL,
> -            .help = "Encrypt the image",
> +            .help = "Encrypt the image with format 'aes'. (Deprecated "
> +                    "in favour of " BLOCK_OPT_ENCRYPT_FORMAT "=aes)",

I don't think we have any strong position on US vs. UK spellings in
user-facing documentation, so I won't insist on any change.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]