[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/5] hw/char: remove console_exit function in sc

From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH 1/5] hw/char: remove console_exit function in sclp
Date: Wed, 26 Apr 2017 17:05:53 +0200

On Wed, 26 Apr 2017 09:42:02 -0500
Eric Blake <address@hidden> wrote:

> On 04/26/2017 07:53 AM, Zihan Yang wrote:
> > Currently, the console_exit function in sclpconsole-lm.c and sclpconsole.c
> > does nothing, so remove them and convert the callback in SCLPEventClass to
> > void. Since there is a NULL check on the DeviceClass exit callback as
> > suggested by Frederic Konrad, it should be safe to remove them.
> When sending a patch series, please be sure to include a 0/5 cover
> letter, to make it easier on automated tooling that processes the list.
> You can use 'git config format.coverletter auto' to make it easier to
> remember this for patches created by 'git format-patch'/'git send-email'.
> More submission hints at: http://wiki.qemu.org/Contribute/SubmitAPatch


Of the hints in the wiki page above, I'd especially like to point out
versioning and change logs.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]