[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v15 21/21] qemu-iotests: Add test case 153 for i
Re: [Qemu-devel] [PATCH v15 21/21] qemu-iotests: Add test case 153 for image locking
Thu, 27 Apr 2017 09:32:00 +0800
On Wed, 04/26 16:49, Kevin Wolf wrote:
> Am 26.04.2017 um 05:34 hat Fam Zheng geschrieben:
> > Signed-off-by: Fam Zheng <address@hidden>
> I'll do the actual review of the test case later, but I already have a
> question... Can we find a way to accept the expected lock losses on
> systems without OFD? I'm using RHEL 7 as my main development OS, so I
> wouldn't like having to deal with false positives there.
Split the lock loss cases to a separate case and _not_run? :)
> Hm... And actually, printing a warning will probably invalidate all the
> other reference outputs, too. After all, every single invocation of
> qemu/qemu-img/qemu-io will print a warning. Maybe that's a bit too much
> even for manual users when they can't do anything about it (which is
> unlike the format probing warning that you can get rid of by simply
> changing your command line).
An idea: make locking=on/off/auto, and auto is on iff OFD is usable, otherwise
off. When user specifies locking=on but OFD is unusable, we print a warning.
Only in this on test case the warning will be printed on RHEL, and it's easy to
filter it out.
[Qemu-devel] [PATCH v15 20/21] file-posix: Add image locking to perm operations, Fam Zheng, 2017/04/25
[Qemu-devel] [PATCH v15 21/21] qemu-iotests: Add test case 153 for image locking, Fam Zheng, 2017/04/25
- Re: [Qemu-devel] [PATCH v15 19/21] osdep: Add qemu_lock_fd and qemu_unlock_fd, (continued)