[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL V2 8/8] COLO-compare: Optimize tcp compare trace

From: Zhang Chen
Subject: Re: [Qemu-devel] [PULL V2 8/8] COLO-compare: Optimize tcp compare trace event
Date: Thu, 27 Apr 2017 10:50:23 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 04/27/2017 10:28 AM, Jason Wang wrote:

On 2017年04月26日 23:55, Peter Maydell wrote:
On 26 April 2017 at 16:18, Peter Maydell <address@hidden> wrote:
On 25 April 2017 at 12:26, Jason Wang <address@hidden> wrote:
From: Zhang Chen <address@hidden>

Optimize two trace events as one, adjust print format make
it easy to read. rename trace_colo_compare_pkt_info_src/dst
to trace_colo_compare_tcp_info.

Signed-off-by: Zhang Chen <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
Hi. This commit has broken building with the UST backend,
because it is effectively reverting commit 2dfe5113b11,
which split this trace line into two events because the
UST backend has a limit on the number of arguments that
a UST event can take.

Could you revert it, please?
...actually it looks like it reverts cleanly on master, so
I'll just revert it directly.

-- PMM

Zheng Chen, consider the UST limitation, I think we can just leave the two tracepoints as is (of course you can improve readability).

OK, I will send a independent patch to improve readability.

Zhang Chen


Zhang Chen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]