[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 3/8] dmg: Limit the output buffer size to a m

From: Ashijeet Acharya
Subject: Re: [Qemu-devel] [PATCH v1 3/8] dmg: Limit the output buffer size to a max of 2MB
Date: Thu, 27 Apr 2017 12:59:45 +0530

On Thu, Apr 27, 2017 at 12:56 PM, Fam Zheng <address@hidden> wrote:
> On Wed, 04/26 17:30, John Snow wrote:
>> Seems OK otherwise, but I would normally expect you to fix the buffering
>> problems first, and then reduce the size of the buffer -- not the other
>> way around. This version introduces new limitations that didn't exist
>> previously (As of this commit, QEMU can't open DMG files with chunks
>> larger than 2MB now, right?)
> Yes, each commit should _not_ introduce issues (compiling failures, functional
> degeneration, etc.), and cannot rely on following commits to fix things 
> screwed
> up in this one.
> This is important for bisectability - each commit can be built and tested in 
> the
> whole git history.

Yes, understood. That's why I am gonna squash it with the last patch
(patch 8) which removes this limitation completely.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]