[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] fsdev: don't allow unknown format in mar
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] fsdev: don't allow unknown format in marshal/unmarshal |
Date: |
Thu, 27 Apr 2017 11:15:22 -0700 (PDT) |
User-agent: |
Alpine 2.10 (DEB 1266 2009-07-14) |
On Thu, 27 Apr 2017, Greg Kurz wrote:
> The code only uses well known format strings. An unknown format token is a
> bug.
>
> Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>
> ---
> fsdev/9p-iov-marshal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fsdev/9p-iov-marshal.c b/fsdev/9p-iov-marshal.c
> index 1d16f8df4bd4..a1c9beddd2e7 100644
> --- a/fsdev/9p-iov-marshal.c
> +++ b/fsdev/9p-iov-marshal.c
> @@ -168,7 +168,7 @@ ssize_t v9fs_iov_vunmarshal(struct iovec *out_sg, int
> out_num, size_t offset,
> break;
> }
> default:
> - break;
> + g_assert_not_reached();
> }
> if (copied < 0) {
> return copied;
> @@ -281,7 +281,7 @@ ssize_t v9fs_iov_vmarshal(struct iovec *in_sg, int
> in_num, size_t offset,
> break;
> }
> default:
> - break;
> + g_assert_not_reached();
> }
> if (copied < 0) {
> return copied;
>
>
- [Qemu-devel] [PATCH v2 0/4] 9pfs: handle transport errors, Greg Kurz, 2017/04/27
- [Qemu-devel] [PATCH v2 1/4] fsdev: don't allow unknown format in marshal/unmarshal, Greg Kurz, 2017/04/27
- Re: [Qemu-devel] [PATCH v2 1/4] fsdev: don't allow unknown format in marshal/unmarshal,
Stefano Stabellini <=
- [Qemu-devel] [PATCH v2 2/4] 9pfs: drop pdu_push_and_notify(), Greg Kurz, 2017/04/27
- [Qemu-devel] [PATCH v2 3/4] virtio-9p: factor out virtio_9p_error_err(), Greg Kurz, 2017/04/27
- [Qemu-devel] [PATCH v2 4/4] 9pfs: handle broken transport, Greg Kurz, 2017/04/27
- Re: [Qemu-devel] [PATCH v2 0/4] 9pfs: handle transport errors, no-reply, 2017/04/27