Re: [Qemu-devel] [PATCH v3 0/4] event: Add source information to SHUTDOWN

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v3 0/4] event: Add source information to SHUTDOWN
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3d27dba RFC: shutdown: Expose full ShutdownType across QMP
f771616 shutdown: Add source information to SHUTDOWN and RESET
3d7747d shutdown: Prepare for use of an enum in reset/shutdown_request
1dd6c70 shutdown: Simplify shutdown_signal

=== OUTPUT BEGIN ===
Checking PATCH 1/4: shutdown: Simplify shutdown_signal...
Checking PATCH 2/4: shutdown: Prepare for use of an enum in 
reset/shutdown_request...
Checking PATCH 3/4: shutdown: Add source information to SHUTDOWN and RESET...
ERROR: line over 90 characters
#144: FILE: hw/arm/omap1.c:1549:
+        qemu_system_shutdown_request(SHUTDOWN_TYPE_GUEST_SHUTDOWN); /* XXX: 
disable wakeup from IRQ */

total: 1 errors, 0 warnings, 882 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/4: RFC: shutdown: Expose full ShutdownType across QMP...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden