qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 05/19] tcg-runtime: add lookup_tb_ptr helper


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v5 05/19] tcg-runtime: add lookup_tb_ptr helper
Date: Fri, 28 Apr 2017 12:32:06 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0

On 04/28/2017 12:29 PM, Alex Bennée wrote:
+    return tcg_ctx.code_gen_epilogue;

Minor comments: I did notice is given we rely on the backends to set this up
in later patches if it is worth adding an assert (or tcg_debug_assert?)
to catch this early if a new backend doesn't set this up?

Sure, I can check for this in tcg_prologue_init and a faulty backend will die very early.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]