Re: [Qemu-devel] [PATCH v5 08/19] target/arm: optimize cross-page direct jumps in softmmu

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> From: "Emilio G. Cota" <address@hidden>
>
> Instead of unconditionally exiting to the exec loop, use the
> lookup_and_goto_ptr helper to jump to the target if it is valid.
>
> Perf impact: see next commit's log.
>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

> ---
>  target/arm/translate.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index 0b5a0bc..facb52f 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -4153,8 +4153,12 @@ static inline void gen_goto_tb(DisasContext *s, int n, 
> target_ulong dest)
>          gen_set_pc_im(s, dest);
>          tcg_gen_exit_tb((uintptr_t)s->tb + n);
>      } else {
> +        TCGv addr = tcg_temp_new();
> +
>          gen_set_pc_im(s, dest);
> -        tcg_gen_exit_tb(0);
> +        tcg_gen_extu_i32_tl(addr, cpu_R[15]);
> +        tcg_gen_lookup_and_goto_ptr(addr);
> +        tcg_temp_free(addr);
>      }
>  }


--
Alex Bennée