Re: [Qemu-devel] [PATCH v3 3/4] qmp: refactor duplicate code

[Eric Blake]

On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote:
> This patchset factor out the duplicate qmp throttle interface code
> that was present in both block and fsdev device files.

Instead of adding the duplicate code in patch 2 then cleaning it out
here, you should refactor this patch to be first (fix existing code in
blockdev.c to make use of the new interfaces), then add the new fsdev
code that uses this code right away.

> 
> Signed-off-by: Pradeep Jagadeesh <address@hidden>
> ---
>  blockdev.c                      | 53 +++----------------------------------
>  fsdev/qemu-fsdev-throttle.c     | 51 +-----------------------------------
>  fsdev/qemu-fsdev.c              |  1 -
>  hmp.c                           | 34 ++++++++++++------------
>  include/qemu/throttle-options.h |  5 ++++
>  util/Makefile.objs              |  1 +
>  util/throttle-options.c         | 58 
> +++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 85 insertions(+), 118 deletions(-)
>  create mode 100644 util/throttle-options.c
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature